Initial `dyn` keyword support & `-std <std-revision>` compiler option #7172

ArielG-NV · 2025-05-20T00:18:14Z

fixes: #7143
fixes: #7146

Goal of PR:

This PR is part of the larger [SP024]Implement SP024 for more robust checking of dynamic dispatch #7115 refactor to how dynamic dispatch works.
The first step is to add the -std <std-revision> flag.
The second step is to provide basic dyn keyword support in AST. This does not include varDecl support since most of these interactions require some keyword support.

Future PR(s) goal:

Support some keyword in AST. With this we will also implement all varDecl interactions between dyn and some.
Add IR support for some and dyn.

Breakdown of PR:

most of the logic is in validateDyn.*. This was done so that in the future when we implement more features we will have an easy time removing/adding restrictions to dyn interfaces.

Breaking changes:

As per spec (https://github.com/shader-slang/spec/pull/14/files), any type conforming to a dyn interface errors if member list contains one of the following: opaque type, non copyable type, or unsized type.
Due to the breaking change, the test tests\compute\dynamic-dispatch-bindless-texture.slang is incorrect. This has been fixed.

Fixes: shader-slang#7146

…aces missing the keyword

Implement sp024 lang 2026

ArielG-NV · 2025-05-20T00:21:26Z

/format

slangbot · 2025-05-20T00:22:54Z

🌈 Formatted, please merge the changes from this PR

slangbot · 2025-05-20T00:22:59Z

🌈 Formatted, please merge the changes from this PR

…support Format code for PR shader-slang#7172

ArielG-NV · 2025-05-20T05:00:36Z

/regenerate-cmdline-ref

slangbot · 2025-05-20T05:18:01Z

🌈 Regenerated command line reference, please merge the changes from this PR

…ement-SP024-dyn-support Regenerate command line reference for PR shader-slang#7172

csyonghe · 2025-05-21T01:16:22Z

include/slang.h

@@ -765,6 +765,7 @@ typedef uint32_t SlangSizeT;
        SLANG_SOURCE_LANGUAGE_SPIRV,
        SLANG_SOURCE_LANGUAGE_METAL,
        SLANG_SOURCE_LANGUAGE_WGSL,
+        SLANG_SOURCE_LANGUAGE_SLANG_2026,


can we remove this? use a new option to track language version.

I think we should be translating -lang 2026 to -lang slang -version 2026

-version is already a reserved keyword. We could make the option named something else like -std 2026 or something ?

Yeah, -std is fine.

csyonghe · 2025-05-21T20:09:22Z

include/slang.h

@@ -765,6 +765,7 @@ typedef uint32_t SlangSizeT;
        SLANG_SOURCE_LANGUAGE_SPIRV,
        SLANG_SOURCE_LANGUAGE_METAL,
        SLANG_SOURCE_LANGUAGE_WGSL,
+        SLANG_SOURCE_LANGUAGE_SLANG_2026,


Yeah, -std is fine.

csyonghe · 2025-05-21T20:11:43Z

source/slang/slang-check-decl.cpp

+        }
+        else if (auto inheritanceDecl = as<InheritanceDecl>(m))
+        {
+            auto inheritedInterfaceDeclRefType = as<DeclRefType>(inheritanceDecl->base.type);


auto inheritedInterfaceDeclRef = isDeclRefTypeOf<InterfaceDecl>(inheritanceDecl->base.type);

csyonghe · 2025-05-21T20:14:46Z

source/slang/slang-check-decl.cpp

+        auto interfaceDecl = as<InterfaceDecl>(decl);
+        if (!interfaceDecl)
+            return;
+        validateDynInterfaceUsage(visitor, sink, optionSet, interfaceDecl);


We shouldn't need to call this from validateDynUsage, instead validateDynInterfaceUsage should be called from visitInterfaceDecl when we check the interface decl itself.

csyonghe · 2025-05-21T20:15:16Z

source/slang/slang-check-decl.cpp

+{
+    visitDecl(interfaceDecl);
+
+    if (interfaceDecl->hasModifier<AnyValueSizeAttribute>())


Check all the dyn interface restrictions here, also make sure to check that dyn interface itself cannot be a generic.

csyonghe · 2025-05-21T20:19:57Z

source/slang/slang-diagnostic-defs.h

@@ -827,6 +827,59 @@ DIAGNOSTIC(
 DIAGNOSTIC(33070, Error, expectedFunction, "expected a function, got '$0'")
 DIAGNOSTIC(33071, Error, expectedAStringLiteral, "expected a string literal")

+// `dyn` and `some` errors
+DIAGNOSTIC(33071, Error, cannotHaveGenericDynInterface, "dyn interfaces cannot be generic: '$0'.")


33071 is duplicated.

csyonghe · 2025-05-21T20:21:33Z

source/slang/slang-check-decl.cpp

+                inheritedInterfaceDecl);
+
+        // `dyn interface` cannot be a generic
+        auto innerInterfaceDecl = as<InterfaceDecl>(genericDecl->inner);


This should be moved to visitInterfaceDecl.

csyonghe · 2025-05-21T20:22:03Z

source/slang/slang-check-decl.cpp

+            return;
+
+        // Ensure not inheriting from `dyn` interface
+        auto inheritedInterfaceDecl = findDynInheritance(visitor, innerAggTypeDecl);


This should be moved to visitInheritanceDecl.

csyonghe · 2025-05-21T20:22:18Z

source/slang/slang-check-decl.cpp

+            return;
+
+        // cannot have extension provide conformance to dyn interface
+        auto inheritedInterfaceDecl = findDynInheritance(visitor, extensionDecl);


Move to visitInheritanceDecl.

csyonghe · 2025-05-21T20:25:13Z

source/slang/slang-check-decl.cpp

@@ -9519,6 +9736,8 @@ void SemanticsDeclBodyVisitor::visitAggTypeDecl(AggTypeDecl* aggTypeDecl)
        getSink()->diagnose(aggTypeDecl->loc, Diagnostics::cannotExportIncompleteType, aggTypeDecl);
    }

+    validateDynUsage(this, getSink(), getOptionSet(), aggTypeDecl);


Why are we calling validateDynUsage from so many different places? If we call it here, then we shouldn't need to call it from SemanticsDeclHeaderVisitor::visitGenericDecl.

I will reduce the calls to validateDynUsage to simplify things.

I just thought of this as a way to "organize" validateDynUsage.

csyonghe · 2025-05-21T20:26:37Z

source/slang/slang-check-decl.cpp

@@ -10057,6 +10276,8 @@ void SemanticsDeclBasesVisitor::visitExtensionDecl(ExtensionDecl* decl)

        _validateCrossModuleInheritance(decl, inheritanceDecl);
    }
+
+    validateDynUsage(this, getSink(), getOptionSet(), decl);


I think if you move the related checks to visitInheritanceDecl you shouldn't need to call validateDynUsage here.

… yet. re-organize the validation as per review, did not fix cmd-line-option yet, that is next.

ArielG-NV · 2025-05-22T01:28:25Z

/format

slangbot · 2025-05-22T01:29:10Z

🌈 Formatted, please merge the changes from this PR

…support Format code for PR shader-slang#7172

ArielG-NV and others added 9 commits May 16, 2025 15:49

Support for -lang 2026

e85d3a8

Fixes: shader-slang#7146

Merge branch 'master' into implement-SP024-lang-2026

2db290a

Add to .md the new command-line option

f39478b

fix documentation

c1ccf8e

Merge branch 'master' into implement-SP024-lang-2026

3b87ce0

initial set of dyn errors. Primarily missing adding dyn to interf…

5930c9d

…aces missing the keyword

Merge branch 'master' into implement-SP024-lang-2026

ffccc26

Merge branch 'shader-slang:master' into implement-SP024-dyn-support

0aee18f

Merge pull request #20 from ArielG-NV/implement-SP024-lang-2026

83866ee

Implement sp024 lang 2026

ArielG-NV requested a review from a team as a code owner May 20, 2025 00:18

ArielG-NV added the pr: non-breaking PRs without breaking changes label May 20, 2025

format code

c5e8498

slangbot mentioned this pull request May 20, 2025

Format code for PR #7172 ArielG-NV/slang#21

Merged

Merge pull request #21 from slangbot/format-7172-implement-SP024-dyn-…

8e65ff3

…support Format code for PR shader-slang#7172

ArielG-NV marked this pull request as draft May 20, 2025 03:48

ArielG-NV added pr: breaking change PRs with breaking changes and removed pr: non-breaking PRs without breaking changes labels May 20, 2025

push test changes and stub tests so CI can verify if everything works

2e17dab

ArielG-NV and others added 3 commits May 19, 2025 22:14

add cmd-line option to docs

569cbf5

Merge branch 'master' into implement-SP024-dyn-support

cdb970a

regenerate command line reference

43aa1b0

slangbot mentioned this pull request May 20, 2025

Regenerate command line reference for PR #7172 ArielG-NV/slang#22

Merged

Merge branch 'master' into implement-SP024-dyn-support

d9d7379

ArielG-NV changed the title ~~Initial dyn keyword support~~ Initial dyn keyword support & -lang 2026 May 20, 2025

ArielG-NV changed the title ~~Initial dyn keyword support & -lang 2026~~ Initial dyn keyword support & -lang 2026 compiler option May 20, 2025

ArielG-NV marked this pull request as ready for review May 20, 2025 15:27

Merge pull request #22 from slangbot/regenerate-cmdline-ref-7172-impl…

5ca4c4c

…ement-SP024-dyn-support Regenerate command line reference for PR shader-slang#7172

csyonghe reviewed May 21, 2025

View reviewed changes

ArielG-NV added 2 commits May 21, 2025 17:01

re-organize the validation as per review, did not fix cmd-line-option…

00ecddb

… yet. re-organize the validation as per review, did not fix cmd-line-option yet, that is next.

remove old and use new command line option

801d9c4

format code

f5b48b3

slangbot mentioned this pull request May 22, 2025

Format code for PR #7172 ArielG-NV/slang#23

Merged

Merge pull request #23 from slangbot/format-7172-implement-SP024-dyn-…

75b1648

…support Format code for PR shader-slang#7172

csyonghe approved these changes May 22, 2025

View reviewed changes

ArielG-NV changed the title ~~Initial dyn keyword support & -lang 2026 compiler option~~ Initial dyn keyword support & -std <std-revision> compiler option May 22, 2025

ArielG-NV enabled auto-merge (squash) May 22, 2025 03:19

Merge branch 'master' into implement-SP024-dyn-support

1234e22

ArielG-NV merged commit 27c6e9b into shader-slang:master May 22, 2025
17 checks passed

jkwak-work mentioned this pull request Jun 16, 2025

Identify key features included in quarterly release #7170

Open

Initial dyn keyword support & -std <std-revision> compiler option #7172

Initial dyn keyword support & -std <std-revision> compiler option #7172

Uh oh!

Conversation

ArielG-NV commented May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ArielG-NV commented May 20, 2025

Uh oh!

slangbot commented May 20, 2025

Uh oh!

slangbot commented May 20, 2025

Uh oh!

ArielG-NV commented May 20, 2025

Uh oh!

slangbot commented May 20, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ArielG-NV May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ArielG-NV commented May 22, 2025

Uh oh!

slangbot commented May 22, 2025

Uh oh!

Uh oh!

Uh oh!

Initial `dyn` keyword support & `-std <std-revision>` compiler option #7172

Initial `dyn` keyword support & `-std <std-revision>` compiler option #7172

ArielG-NV commented May 20, 2025 •

edited

Loading

ArielG-NV May 21, 2025 •

edited

Loading