Skip to content

Conversation

skallweitNV
Copy link
Collaborator

  • change existing GPU tests using TEST_CASE to use GPU_TEST_CASE
  • Add GpuTestFlags::NoDevice to allow tests to control device creation (with extra properties etc.)
  • Pass ctx to GPU test functions
  • Pass current device type in GpuTestCtx
  • Remove runGpuTests

- change existing GPU tests using TEST_CASE to use GPU_TEST_CASE
- Add GpuTestFlags::NoDevice to allow tests to control device creation (with extra properties etc.)
- Pass ctx to GPU test functions
- Pass current device type in GpuTestCtx
- Remove runGpuTests
@skallweitNV skallweitNV requested a review from a team as a code owner September 4, 2025 07:57
Copy link
Contributor

@ccummingsNV ccummingsNV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find the 'NoDevice' api pretty confusing tbh - took me a while to realise it was an extra flag - initially I thought Vulkan | D3D12 | NoDevice meant 'run 3 versions of this test, with vulkan, then d3d12, then no device'.

Looks technically solid though.

@skallweitNV skallweitNV merged commit 7f90fc5 into main Sep 4, 2025
20 checks passed
@skallweitNV skallweitNV deleted the use-gpu-test-case branch September 4, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants