-
Notifications
You must be signed in to change notification settings - Fork 3.1k
[NVIDIA] Build CUDA 13 #11299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[NVIDIA] Build CUDA 13 #11299
Conversation
Summary of ChangesHello @johnnynunez, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the project's compatibility and performance by introducing full support for CUDA 13. It integrates critical upstream updates for core kernels, optimizes the build process for various architectures, and addresses specific memory reporting challenges on NVIDIA's Unified Memory Architecture devices. These changes collectively aim to broaden hardware support, streamline development, and improve resource utilization. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for building with CUDA 13, adds specific support for Jetson Orin devices, and optimizes the build process by reducing binary sizes for x86 platforms. The changes look good overall, but I've identified a couple of areas for improvement. There's a redundant code path in python/sglang/srt/utils/common.py
that can be refactored for clarity and efficiency. More critically, there's a bug in sgl-kernel/build.sh
where a conditional block is unreachable due to a duplicated condition, which could affect builds for different CUDA versions. I've provided suggestions to address these points.
Motivation
Make Possible to build with CUDA 13.
Modifications