Skip to content

Conversation

polisettyvarma
Copy link

Motivation

to support xpu

Modifications

add xpu memory support to get_device_memory_capacity

Accuracy Tests

Not Applicable

Benchmarking and Profiling

Not Applicable

Checklist

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @polisettyvarma, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request expands the system's ability to detect and report device memory capacity by adding support for XPU devices. This enhancement ensures that applications can correctly identify and utilize memory resources on systems equipped with XPU hardware, improving overall compatibility and resource management.

Highlights

  • XPU Memory Capacity Function: Introduced a new function get_xpu_memory_capacity to specifically query and return the memory capacity of XPU devices, ensuring compatibility with Intel's XPU architecture.
  • Universal Device Memory Detection: Updated the get_device_memory_capacity function to include support for XPU devices, allowing it to dynamically retrieve memory information for XPU alongside existing CUDA, HPU, and NPU devices.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for XPU memory capacity retrieval in utils.py. The implementation of get_xpu_memory_capacity has a typo and a copy-paste error. I've provided a suggestion to fix these issues and to make the function's behavior consistent with other memory capacity functions in the file.

@polisettyvarma
Copy link
Author

@polisettyvarma
Copy link
Author

@mingfeima please review

@mingfeima
Copy link
Collaborator

enable CI now

@mingfeima
Copy link
Collaborator

@DiweiSun let's wait for xpu CI and re-run this one again.

@mingfeima mingfeima marked this pull request as draft September 22, 2025 04:22
@mingfeima mingfeima added intel xpu intel gpu with device `torch.xpu` labels Sep 22, 2025
@polisettyvarma polisettyvarma changed the title add xpu memory support in get_device_memory_capacity of utils.py [Intel XPU] add xpu memory support which helps with default chunked prefill size for OOM scenarios Sep 29, 2025
@polisettyvarma polisettyvarma changed the title [Intel XPU] add xpu memory support which helps with default chunked prefill size for OOM scenarios [Intel GPU] add xpu memory support which helps with default chunked prefill size for OOM scenarios Sep 29, 2025
@polisettyvarma polisettyvarma changed the title [Intel GPU] add xpu memory support which helps with default chunked prefill size for OOM scenarios [Intel GPU] add xpu device memory support which helps with default chunked prefill size for OOM scenarios Sep 29, 2025
@polisettyvarma polisettyvarma reopened this Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

intel xpu intel gpu with device `torch.xpu`

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants