Skip to content

RestyleDamage: Ensure correctness with externally set bits #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

RestyleDamage: Ensure correctness with externally set bits #225

wants to merge 1 commit into from

Conversation

nicoburns
Copy link
Collaborator

@nicoburns nicoburns commented Aug 7, 2025 •
edited
Loading

Ensure's that methods defined by the bitflags crate (all, contains, empty, etc) take into account the possibility of externally set bits. See: https://docs.rs/bitflags/latest/bitflags/#externally-defined-flags

Loirooriol
Loirooriol reviewed Aug 7, 2025
View reviewed changes
Copy link
Contributor

@Loirooriol Loirooriol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC in some places we were using truncate() or such to remove external bits. Seems your patch would break that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Loirooriol Loirooriol Loirooriol left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicoburns @Loirooriol