Skip to content

Conversation

@jdm
Copy link
Member

@jdm jdm commented Sep 7, 2021

No description provided.

@servo-wpt-sync
Copy link
Collaborator

Error syncing changes upstream. Logs saved in error-snapshot-1630993584465.

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Sep 7, 2021
@servo-wpt-sync
Copy link
Collaborator

Error syncing changes upstream. Logs saved in error-snapshot-1630993587900.

@jdm
Copy link
Member Author

jdm commented Sep 8, 2021

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit a6a0f52 has been approved by jdm

@servo-wpt-sync
Copy link
Collaborator

Error syncing changes upstream. Logs saved in error-snapshot-1631118569350.

@servo-wpt-sync
Copy link
Collaborator

Error syncing changes upstream. Logs saved in error-snapshot-1631118571395.

@highfive highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Sep 8, 2021
@bors-servo
Copy link
Contributor

⌛ Testing commit a6a0f52 with merge e842eb0...

@servo-wpt-sync
Copy link
Collaborator

Error syncing changes upstream. Logs saved in error-snapshot-1631118573211.

@highfive highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Sep 8, 2021
bors-servo added a commit that referenced this pull request Sep 8, 2021
Update rustc to latest nightly.

None
@servo-wpt-sync
Copy link
Collaborator

Error syncing changes upstream. Logs saved in error-snapshot-1631118573788.

@CYBAI
Copy link
Member

CYBAI commented Sep 8, 2021

I'm so confused why @servo-wpt-sync is triggered for this PR 🤔

@jdm
Copy link
Member Author

jdm commented Sep 8, 2021

I think that's happening because I need to regenerate the access tokens that servo-wpt-sync uses.

@jdm
Copy link
Member Author

jdm commented Sep 8, 2021

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 6093a19 has been approved by jdm

@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. S-awaiting-review There is new code that needs to be reviewed. labels Sep 8, 2021
@bors-servo
Copy link
Contributor

⌛ Testing commit 6093a19 with merge a59baf3...

bors-servo added a commit that referenced this pull request Sep 8, 2021
Update rustc to latest nightly.

None
@jdm
Copy link
Member Author

jdm commented Sep 8, 2021

rust-lang/rust#88764

@bors-servo
Copy link
Contributor

💔 Test failed - checks-github

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Sep 8, 2021
@CYBAI
Copy link
Member

CYBAI commented Sep 9, 2021

Build fail on Windows UWP jobs 👀

Details
error[E0599]: no method named `raw` found for struct `Handle` in the current scope
   --> C:\Rust\.rustup\toolchains\nightly-2021-09-06-x86_64-pc-windows-msvc\lib\rustlib\src\rust\library\std\src\sys\windows\fs.rs:360:29
    |
360 |                 self.handle.raw(),
    |                             ^^^ method not found in `Handle`
    |
   ::: C:\Rust\.rustup\toolchains\nightly-2021-09-06-x86_64-pc-windows-msvc\lib\rustlib\src\rust\library\std\src\sys\windows\handle.rs:17:1
    |
17  | pub struct Handle(OwnedHandle);
    | ------------------------------- method `raw` not found for this

error[E0599]: no method named `raw` found for struct `Handle` in the current scope
   --> C:\Rust\.rustup\toolchains\nightly-2021-09-06-x86_64-pc-windows-msvc\lib\rustlib\src\rust\library\std\src\sys\windows\fs.rs:388:29
    |
388 |                 self.handle.raw(),
    |                             ^^^ method not found in `Handle`
    |
   ::: C:\Rust\.rustup\toolchains\nightly-2021-09-06-x86_64-pc-windows-msvc\lib\rustlib\src\rust\library\std\src\sys\windows\handle.rs:17:1
    |
17  | pub struct Handle(OwnedHandle);
    | ------------------------------- method `raw` not found for this

error[E0599]: no function or associated item named `new` found for struct `Handle` in the current scope
  --> C:\Rust\.rustup\toolchains\nightly-2021-09-06-x86_64-pc-windows-msvc\lib\rustlib\src\rust\library\std\src\sys\windows\stdio_uwp.rs:28:26
   |
28 |     let handle = Handle::new(handle);
   |                          ^^^ function or associated item not found in `Handle`
   |
  ::: C:\Rust\.rustup\toolchains\nightly-2021-09-06-x86_64-pc-windows-msvc\lib\rustlib\src\rust\library\std\src\sys\windows\handle.rs:17:1
   |
17 | pub struct Handle(OwnedHandle);
   | ------------------------------- function or associated item `new` not found for this

error[E0599]: no method named `write` found for struct `ManuallyDrop<_>` in the current scope
    --> C:\Rust\.rustup\toolchains\nightly-2021-09-06-x86_64-pc-windows-msvc\lib\rustlib\src\rust\library\std\src\sys\windows\stdio_uwp.rs:29:31
     |
29   |     ManuallyDrop::new(handle).write(data)
     |                               ^^^^^ method not found in `ManuallyDrop<_>`
     |
     = note: `ManuallyDrop::new(handle)` is a function, perhaps you wish to call it
     = help: items from traits can only be used if the trait is implemented and in scope
note: `io::Write` defines an item `write`, perhaps you need to implement it
    --> C:\Rust\.rustup\toolchains\nightly-2021-09-06-x86_64-pc-windows-msvc\lib\rustlib\src\rust\library\std\src\io\mod.rs:1368:1
     |
1368 | pub trait Write {
     | ^^^^^^^^^^^^^^^

error[E0599]: no function or associated item named `new` found for struct `Handle` in the current scope
  --> C:\Rust\.rustup\toolchains\nightly-2021-09-06-x86_64-pc-windows-msvc\lib\rustlib\src\rust\library\std\src\sys\windows\stdio_uwp.rs:41:30
   |
41 |         let handle = Handle::new(handle);
   |                              ^^^ function or associated item not found in `Handle`
   |
  ::: C:\Rust\.rustup\toolchains\nightly-2021-09-06-x86_64-pc-windows-msvc\lib\rustlib\src\rust\library\std\src\sys\windows\handle.rs:17:1
   |
17 | pub struct Handle(OwnedHandle);
   | ------------------------------- function or associated item `new` not found for this

error[E0599]: no method named `read` found for struct `ManuallyDrop<_>` in the current scope
   --> C:\Rust\.rustup\toolchains\nightly-2021-09-06-x86_64-pc-windows-msvc\lib\rustlib\src\rust\library\std\src\sys\windows\stdio_uwp.rs:42:35
    |
42  |         ManuallyDrop::new(handle).read(buf)
    |                                   ^^^^ method not found in `ManuallyDrop<_>`
    |
    = note: `ManuallyDrop::new(handle)` is a function, perhaps you wish to call it
    = help: items from traits can only be used if the trait is implemented and in scope
note: `io::Read` defines an item `read`, perhaps you need to implement it
   --> C:\Rust\.rustup\toolchains\nightly-2021-09-06-x86_64-pc-windows-msvc\lib\rustlib\src\rust\library\std\src\io\mod.rs:520:1
    |
520 | pub trait Read {
    | ^^^^^^^^^^^^^^

@jdm
Copy link
Member Author

jdm commented Sep 9, 2021

Yep, I filed a rust-lang issue about it per #28591 (comment).

@CYBAI
Copy link
Member

CYBAI commented Sep 9, 2021

ah, I see! thank you! 🙏

@jdm
Copy link
Member Author

jdm commented Sep 24, 2021

rust-lang/rust#88587 just merged so this can update to a newer nightly.

@servo-wpt-sync
Copy link
Collaborator

Error syncing changes upstream. Logs saved in error-snapshot-1635702484672.

@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Oct 31, 2021
@servo-wpt-sync
Copy link
Collaborator

Error syncing changes upstream. Logs saved in error-snapshot-1635702487633.

@servo-wpt-sync
Copy link
Collaborator

Error syncing changes upstream. Logs saved in error-snapshot-1635702487885.

@servo-wpt-sync
Copy link
Collaborator

Error syncing changes upstream. Logs saved in error-snapshot-1635770794008.

@jdm
Copy link
Member Author

jdm commented Nov 1, 2021

Oh, the errors come from having an empty PR body :)

@jdm
Copy link
Member Author

jdm commented Nov 1, 2021

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 01681e7 has been approved by jdm

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Nov 1, 2021
@servo-wpt-sync
Copy link
Collaborator

Error syncing changes upstream. Logs saved in error-snapshot-1635776393516.

@bors-servo
Copy link
Contributor

⌛ Testing commit 01681e7 with merge 9693111...

@servo-wpt-sync
Copy link
Collaborator

Error syncing changes upstream. Logs saved in error-snapshot-1635776394362.

@bors-servo
Copy link
Contributor

☀️ Test successful - checks-github, status-taskcluster
Approved by: jdm
Pushing 9693111 to master...

@bors-servo bors-servo merged commit 9693111 into master Nov 1, 2021
@bors-servo bors-servo deleted the jdm-patch-51 branch November 1, 2021 16:31
@servo-wpt-sync
Copy link
Collaborator

Error syncing changes upstream. Logs saved in error-snapshot-1635784316494.

@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 1, 2021
@servo-wpt-sync
Copy link
Collaborator

Error syncing changes upstream. Logs saved in error-snapshot-1635784318218.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants