perf: url encode path segments in longer string slices #1026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1026 +/- ##
=======================================
Coverage ? 79.93%
=======================================
Files ? 24
Lines ? 4322
Branches ? 0
=======================================
Hits ? 3455
Misses ? 867
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Scripter17
reviewed
Feb 7, 2025
url/src/parser.rs
Outdated
| @@ -1305,7 +1367,7 @@ impl<'a> Parser<'a> { | |||
| } | |||
| } | |||
| if scheme_type.is_file() { | |||
| // while url’s path’s size is greater than 1 | |||
| // while url's path’s size is greater than 1 | |||
| // and url’s path[0] is the empty string, | |||
There was a problem hiding this comment.
Oops. I missed reverting that after I noticed that kind of quote is used everywhere in the codebase (habit I have because in Deno, we avoid using non-ascii characters in JS because it causes the source code to be stored less efficiently. Example: microsoft/TypeScript#53608). Thanks!
|
It fully occurred to me how annoying it must be to get a "you missed a smudge" review from a rando on your genuinely very impressive work so I want to redeem myself: You're awesome URL parsing has been a bit of a bottleneck in my current main project for a while and all your work does a pretty good dent in it Seeing all your pull requests was a very nice thing to wake up and look forward to |
dsherret
commented
Feb 8, 2025
Signed-off-by: David Sherret <[email protected]>
|
Not annoying. Thanks! |
kodiakhq bot
pushed a commit
to pdylanross/fatigue
that referenced
this pull request
Aug 21, 2025
Bumps url from 2.5.4 to 2.5.5. Release notes Sourced from url's releases. v2.5.5 What's Changed ci: downgrade crates when building for Rust 1.67.0 by @mxinden in servo/rust-url#1003 ci: run unit tests with sanitizers by @mxinden in servo/rust-url#1002 fix small typo by @hkBst in servo/rust-url#1011 chore: fix clippy errors on main by @dsherret in servo/rust-url#1019 perf: remove heap allocation in parse_query by @dsherret in servo/rust-url#1020 perf: slightly improve parsing a port by @dsherret in servo/rust-url#1022 perf: improve to_file_path() by @dsherret in servo/rust-url#1018 perf: make parse_scheme slightly faster by @dsherret in servo/rust-url#1025 update LICENSE-MIT by @wmjae in servo/rust-url#1029 perf: url encode path segments in longer string slices by @dsherret in servo/rust-url#1026 Disable the default features on serde by @rilipco in servo/rust-url#1033 docs: base url relative join by @tisonkun in servo/rust-url#1013 perf: remove heap allocation in parse_host by @dsherret in servo/rust-url#1021 Update tests to Unicode 16.0 by @hsivonen in servo/rust-url#1045 Add some some basic functions to Mime by @mrobinson in servo/rust-url#1047 ran cargo clippy --fix -- -Wclippy::use_self by @mrobinson in servo/rust-url#1048 Fix MSRV and clippy CI by @Manishearth in servo/rust-url#1058 Update Url::domain docs to show that it includes subdomain by @supercoolspy in servo/rust-url#1057 set_hostname should error when encountering colon ':' by @edgul in servo/rust-url#1060 version bump to 2.5.5 by @edgul in servo/rust-url#1061 New Contributors @mxinden made their first contribution in servo/rust-url#1003 @hkBst made their first contribution in servo/rust-url#1011 @wmjae made their first contribution in servo/rust-url#1029 @rilipco made their first contribution in servo/rust-url#1033 @tisonkun made their first contribution in servo/rust-url#1013 @supercoolspy made their first contribution in servo/rust-url#1057 Full Changelog: servo/[email protected] Commits a40f904 version bump to 2.5.5 (#1061) cf305db set_hostname should error when encountering colon ':' (#1060) 88826bd Update Url::domain docs to show that it includes subdomain (#1057) c3bbf66 Fix MSRV and clippy CI (#1058) dbd5261 ran cargo clippy --fix -- -Wclippy::use_self (#1048) 9f6e92e Add some some basic functions to Mime (#1047) 68f151c Update tests to Unicode 16.0 (#1045) 7cff874 perf: remove heap allocation in parse_host (#1021) 968e862 docs: base url relative join (#1013) 2ce2e12 Disable the default features on serde. (#1033) Additional commits viewable in compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase. Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: @dependabot rebase will rebase this PR @dependabot recreate will recreate this PR, overwriting any edits that have been made to it @dependabot merge will merge this PR after your CI passes on it @dependabot squash and merge will squash and merge this PR after your CI passes on it @dependabot cancel merge will cancel a previously requested merge and block automerging @dependabot reopen will reopen this PR if it is closed @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After: