Skip to content

Update phf to 0.10 #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors-servo merged 1 commit into from
Feb 23, 2022
Merged

Update phf to 0.10 #461

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions markup5ever/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ path = "lib.rs"

[dependencies]
string_cache = "0.8"
phf = "0.9"
phf = "0.10"
Copy link

@shepmaster shepmaster Feb 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing I've done before when the code didn't need to change at all is to have a wide version range:

- phf = "0.9"
+ phf = { version = ">= 0.9, < 0.11" }

Copy link
Contributor Author

@sugar700 sugar700 Feb 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wouldn't really be correct. Because phf has a phf_codegen crate it's possible for Cargo to resolve phf 0.9 and phf_codegen 0.10, which could possibly be bad.

Copy link

@shepmaster shepmaster Feb 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be the responsibility of the phf crate to specify which phf_codegen crate it needs.

If this crate allowed phf {0.8,0.9,0.10} then Cargo could pick any one of those, then would resolve the dependencies for the version it picked.

Copy link
Contributor Author

@sugar700 sugar700 Feb 24, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phf_codegen is a build-dependency for this crate (see below), and there would be nothing stopping Cargo from picking a different version here. As far Cargo is concerned those crates are unrelated.

tendril = "0.4"
log = "0.4"

[build-dependencies]
string_cache_codegen = "0.5.1"
phf_codegen = "0.9"
phf_codegen = "0.10"