-
Notifications
You must be signed in to change notification settings - Fork 80
Support for Volumes #194
Support for Volumes #194
Conversation
# Conflicts: # package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @ddoowa!
I have a few suggestions, apart from that I think it's better to diverge as less as possible from the format that a pod expect for volumes. In particular I would suggest:
functions:
my-function:
handler: handler.myFunction
volumes:
- name: my-volume
persistentVolumeClaim:
claimName: my-volume
volumeMounts:
- mountPath: /foo/bar
name: my-volume
That way it's easier for people to know the format and it's easier to use in the code (you don't need to parse and translate the information from the function spec).
@andresmgot That sounds even better, not sure why i didn't think of it, but i have now made the necessary changes to support this format, and addressed other comments, looking forward to the merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks for the changes!
Added Functionality to define volumes to attach the function pods to, also refactored the process to define secrets to re-use the same underlying function.
example volume definitions: