This repository was archived by the owner on Dec 9, 2024. It is now read-only.
adds support for aws-iam-authenticator #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresmgot
approved these changes
Oct 28, 2019
lib/helpers.js
Outdated
| } | ||
| return accessToken; | ||
| } else if (cmd && cmd === 'aws') { | ||
| } else if (cmd && awsClis.indexOf(cmd) !== -1) { |
There was a problem hiding this comment.
a way a bit more readable would be awsClis.includes(cmd).
andresmgot
reviewed
Oct 28, 2019
lib/helpers.js
Outdated
| _.get(userInfo, 'user.auth-provider.config.id-token'); | ||
| const accessToken = _.get(userInfo, 'user.auth-provider.config.access-token'); | ||
| let cmd = _.get(userInfo, 'user.exec.command'); | ||
| const awsClis = ['aws', 'aws-iam-authenticator'] |
There was a problem hiding this comment.
also, you are missing a ; at the end of this line
|
made syntax, linting changes and upticked the version @andresmgot, let me know if you any other changes are required. |
andresmgot
approved these changes
Oct 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.