This repository was archived by the owner on Dec 9, 2024. It is now read-only.
Add support for "dynamic" EKS token auth #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresmgot
approved these changes
Oct 21, 2019
lib/helpers.js
Outdated
| if (args) { | ||
| cmd = `${cmd} ${args.join(' ')}`; | ||
| } | ||
| const profile = _.find(userInfo.user.exec.env, e => e.name === 'AWS_PROFILE'); |
There was a problem hiding this comment.
if userInfo.user.exec is undefined this will crash, you can try:
const env = _.get(userInfo, 'user.exec.env', []);
const profile = ...
lib/helpers.js
Outdated
| throw new Error(`Failed to refresh token: ${err.message}`); | ||
| } | ||
| const resultObj = JSON.parse(output); | ||
| return resultObj.status.token; |
There was a problem hiding this comment.
Here I would also verify that status is defined
|
Thanks for the feedback @andresmgot. Let me know if this is not what you had in mind. |
andresmgot
approved these changes
Oct 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS EKS utilizes the kubeconfig support for client-go credential plugins to execute the
awsCLI command to receive user credentials when authenticating to an EKS cluster. This PR adds support to serverless-kubeless to use such configs as another access token mechanism and should address issue #140(Thanks to the Javascript Kubernetes Client cloud_auth for the general idea of how to do this.)