Skip to content

WIP Inline AbstractServerImplBuilder #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sergiitk wants to merge 8 commits into from
Closed

WIP Inline AbstractServerImplBuilder #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
89c4f78
core: Remove last references to AbstractServerImplBuilder
sergiitk Sep 14, 2020
dabc2be
Inline AbstractServerImplBuilder: public ServerBuilder API
sergiitk Sep 14, 2020
9cc30fd
Inline AbstractServerImplBuilder: move protected
sergiitk Sep 16, 2020
58bb66e
Inline AbstractServerImplBuilder: the rest and properties
sergiitk Sep 16, 2020
980beab
Remove AbstractServerImplBuilder
sergiitk Sep 16, 2020
953dbf3
Static Preconditions
sergiitk Sep 16, 2020
2880cab
Less noise in tests
sergiitk Sep 16, 2020
db8c80f
Review methond visibility
sergiitk Sep 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
330 changes: 0 additions & 330 deletions core/src/main/java/io/grpc/internal/AbstractServerImplBuilder.java
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion core/src/main/java/io/grpc/internal/ServerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ public final class ServerImpl extends io.grpc.Server implements InternalInstrume
* @param rootContext context that callbacks for new RPCs should be derived from
*/
ServerImpl(
AbstractServerImplBuilder<?> builder,
ServerImplBuilder builder,
List<? extends InternalServer> transportServers,
Context rootContext) {
this.executorPool = Preconditions.checkNotNull(builder.executorPool, "executorPool");
Expand Down
Loading