Fix/issue_3264 #3268
Fix/issue_3264 #3268
Conversation
… `seqan3::bitpacked_sequence`. seqan#3264 Further constraints the conversion constructors of the nucleotide and aminoacid base alphabet types to only consider conversion if all requirements are fulfilled. This is now represented by the specific concept `convertable_to_through_char_representation`. Through this proxy types will not be converted through their char representation but will be implicitly converted to their underling base alphabet type, e.g. dna4, and then copied/moved using the copy/move constructor of the underlying base alphabet type.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
seqan-actions
added
lint
eseiler
left a comment
eseiler
left a comment
There was a problem hiding this comment.
Do you have an opinion regarding #3267 (comment) ?
| #include <vector> | ||
|
|
There was a problem hiding this comment.
| #include <vector> |
Needed?
There was a problem hiding this comment.
Well, I am using a std::vector. It might be included by the helper.hpp already. Not including it has the potential that if some other code is refactored this test might not compile anymore since vector is not included through some dependent includes. Adding it makes clear, that I need it in the test.
But frankly, I don't care too much. What is the preferred policy here?
There was a problem hiding this comment.
Ah, didn't see the result_t. It's fine then
I answered on the issue page. |
seqan-actions
added
lint
3 participants
Further constraints the conversion constructors of the nucleotide and aminoacid base alphabet types to only consider conversion if all requirements are fulfilled. This is now represented by the specific concept
convertable_to_through_char_representation.Through this proxy types will not be converted through their char representation but will be implicitly converted to their underling base alphabet type, e.g. dna4, and then copied/moved using the copy/move constructor of the underlying base alphabet type.
Fixes #3264
Fixes #3267