fix(publish-dry-run): temporarily remove the addition of dry-running the publish step #1019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travi
force-pushed
the
disable-dry-run
branch
from
74e2e21 to
1077cdf
Compare
…the publish step since it fails when run from the `verifyConditions` hook because the version has not yet been changed and conflicts with the existing published version
travi
force-pushed
the
disable-dry-run
branch
from
1077cdf to
30bd176
Compare
|
🎉 This PR is included in version 13.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since it fails when run from the
verifyConditionshook because the version has not yet been changed and conflicts with the existing published versionour existing tests for this plugin do not simulate a tag already existing, so we need to add that context to our tests before re-introducing this feature. this went beyond what was necessary for trusted publishing, so backing this part back out in order to clear the way for trusted publishing without introducing new errors for folks