Skip to content

Conversation

codchen
Copy link
Collaborator

@codchen codchen commented Aug 25, 2025

Describe your changes and provide context

This adds two conditions to determine whether a log should be included:

  • if the receipt has status failed (0), it should never be included
  • if the receipt's block number doesn't match the block's block number (e.g. in the case of a failed tx with higher nonce), it should never be included.

The conditions right now are explicitly listed out so looks lengthy. Eventually we can simplify it once we are confident with the logic.

Testing performed to validate your change

unit test & test on node

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants