Add \f as whitespace #227
Merged
Add \f as whitespace #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #219
gpetrou
reviewed
Jun 10, 2025
| @@ -105,6 +105,7 @@ public static bool IsWhiteSpaceOrNewLine(char ch) | |||
| return (ch <= 32 && | |||
| ((ch == 32) || // space | |||
| (ch == '\n') || | |||
| (ch == '\f') || | |||
| (ch == '\r') || | |||
| (ch == '\t') || // horizontal tab | |||
| (ch == '\v'))) | |||
There was a problem hiding this comment.
@sebastienros thanks for fixing this.
Since these are consecutive now, is it worth checking the range instead? I mean something like ch >= 0x09 && ch <= 0x0d
| 0x09 | 9 | HT | Horizontal Tab |
| 0x0a | 10 | LF | Line Feed |
| 0x0b | 11 | VT | Vertical Tab |
| 0x0c | 12 | FF | Form Feed |
| 0x0d | 13 | CR | Carriage Return |
There was a problem hiding this comment.
Since this is a test it doesn't matter to me. On the contrary even since what it's checking it more obvious (again at least to me).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #219
@lahma I updated the characters mask manually, are you mad?
/cc @gpetrou