Warn when #[DataProvider*] attributes are mixed with #[TestWith*] attributes
#6273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Jul 13, 2025
stof
reviewed
Jul 18, 2025
src/Metadata/Api/DataProvider.php
Outdated
| MetadataCollection::fromArray([]), | ||
| Event\TestData\TestDataCollection::fromArray([]), | ||
| ), | ||
| 'Mixing #[DataProvider] and #[TestWith] attributes is not supported, only the data provided by #[DataProvider] will be used', |
There was a problem hiding this comment.
this will be confusing when using DataProviderExternal or TestWithJson. The message should probably deal better with such cases
There was a problem hiding this comment.
good point, didn't think about all these other types of providers. will adjust the wording.
staabm
force-pushed
the
warn-mixed-dataprovider
branch
from
f17a6a0 to
0e5d604
Compare
staabm
force-pushed
the
warn-mixed-dataprovider
branch
from
0e5d604 to
cda60ae
Compare
sebastianbergmann
added
type/enhancement
sebastianbergmann
changed the title
#[DataProvider*] attributes are mixed with #[TestWith*] attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6265