Skip to content

updated Part.content_type() to return Mime.as_ref() string #1046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 5, 2023
Merged

updated Part.content_type() to return Mime.as_ref() string #1046

merged 2 commits into from
Jun 5, 2023

Conversation

@aedmondson
Copy link
Contributor

@aedmondson aedmondson commented Jun 3, 2023

Probably resolves #1042.

@seanmonstar
Copy link
Owner

seanmonstar commented Jun 3, 2023

Thanks for the PR!

This would be a breaking change, though. A fix could be to change the function to not call type_(), just return the full string.

@aedmondson
Copy link
Contributor Author

aedmondson commented Jun 3, 2023 •
edited
Loading

I see, I misunderstood the comments on the issue. I'll change that now.

@aedmondson aedmondson changed the title updated Part.content_type() to return full Mime struct updated Part.content_type() to return Mime.as_ref() string Jun 3, 2023
@aedmondson
Copy link
Contributor Author

aedmondson commented Jun 3, 2023

@seanmonstar This should be ready to go

@seanmonstar seanmonstar enabled auto-merge (squash) June 5, 2023 21:13
@seanmonstar seanmonstar merged commit d73dc54 into seanmonstar:master Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanmonstar seanmonstar seanmonstar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Part::content_type only returns the media type, not the subtype

2 participants

@aedmondson @seanmonstar