Fix no space after colon #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b2625f3.
This was referenced Jun 11, 2024
seanmonstar
force-pushed
the
fix-no-space-after-colon
branch
from
fb52887 to
a4307e3
Compare
|
@seanmonstar sorry for the trouble, I did miss a cursor-advancing instruction in one spot. Thanks for landing a testcase for this. I've opened #175 which contains a plain reapply of your revert, plus a fixing commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was noticed with a bisect the bug was introduced in this commit, so I'm reverting it for now to get a fix out faster.
cc @lucab
Fixes #172
Fixes #173