feat: Add Thermostat Climate Preset Management #680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razor-x
reviewed
Mar 5, 2025
There was a problem hiding this comment.
Great! Mostly minor code suggestions. I think the main pattern we should try and align on is how to split our the create/update stuff. @mikewuu worked on this when we implemented the access code forms, and I feel like we mostly figured it out.
We don't have to solve that in this PR. If you can take a fist pass at some of the smaller things I flagged, we can come back to anything you want to move out of scope of this PR.
src/lib/seam/thermostats/use-create-thermostat-climate-preset.ts
Outdated
Show resolved
Hide resolved
src/lib/seam/thermostats/use-create-thermostat-climate-preset.ts
Outdated
Show resolved
Hide resolved
src/lib/seam/thermostats/use-create-thermostat-climate-preset.ts
Outdated
Show resolved
Hide resolved
razor-x
reviewed
Mar 13, 2025
razor-x
reviewed
Mar 13, 2025
razor-x
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CleanShot.2025-03-12.at.19.10.21.mp4