Skip to content

Conversation

gabyx
Copy link
Contributor

@gabyx gabyx commented May 12, 2025

Proposed Changes

  • Add registry type RegistryTilt which will compute the image ref from tilt env. vars.

Types of Changes

What types of changes does your contribution introduce? Put an x in the boxes
that apply

  • A bug fix (non-breaking change which fixes an issue). Use MR tag
    bugfix.
  • A new feature (non-breaking change which adds functionality). Use MR
    tag feature.
  • A breaking change (fix or feature that would cause existing
    functionality to not work as expected). Use MR tag feature.
  • A non-productive update (documentation, tooling, etc. if none of the
    other choices apply). Use MR tag chore.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.

Further Comments

Copy link

codecov bot commented May 12, 2025

Codecov Report

Attention: Patch coverage is 18.18182% with 18 lines in your changes missing coverage. Please review.

Project coverage is 59.25%. Comparing base (2ccc079) to head (fcc69c8).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/registry/registry-type.go 7.69% 12 Missing ⚠️
pkg/image/images.go 33.33% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
+ Coverage   58.99%   59.25%   +0.25%     
==========================================
  Files          87       87              
  Lines        4468     4481      +13     
==========================================
+ Hits         2636     2655      +19     
+ Misses       1611     1601      -10     
- Partials      221      225       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gabyx gabyx force-pushed the feat/add-registry-type-tilt branch from e931422 to 4db35ff Compare May 12, 2025 21:04
@gabyx gabyx merged commit c6f1860 into main May 12, 2025
5 checks passed
@gabyx gabyx deleted the feat/add-registry-type-tilt branch May 12, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant