Skip to content

GetEntry fixes, key ordering, path manipulation fixes #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hansthienpondt merged 6 commits into from
Dec 6, 2024
Merged

GetEntry fixes, key ordering, path manipulation fixes #134

hansthienpondt merged 6 commits into from
Dec 6, 2024

Conversation

@alexandernorth
Copy link
Contributor

@alexandernorth alexandernorth commented Nov 20, 2024

This PR addresses a few issues regarding schema loading:

  • Entry lookups where cases do not have the name of the child
  • Improved/Refactored module lookups for GetEntry
  • getentry fixes in case a prefix is a part of the path
  • buildpath fixes for choicecases
  • path resolution fixed for some paths where a choicecase would erroneously be part of the path

@alexandernorth alexandernorth mentioned this pull request Nov 21, 2024
Merged
@alexandernorth alexandernorth force-pushed the fix/refactor-getentry-and-naming branch from 8eb4b1c to 1983d34 Compare December 3, 2024 13:52
@hansthienpondt
Copy link
Contributor

hansthienpondt commented Dec 6, 2024 

==============================================================================
02-Crud                                                               | PASS |
117 tests, 117 passed, 0 failed
==============================================================================

@hansthienpondt hansthienpondt merged commit 453b100 into sdcio:main Dec 6, 2024
@alexandernorth alexandernorth deleted the fix/refactor-getentry-and-naming branch December 9, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henderiw henderiw Awaiting requested review from henderiw henderiw is a code owner

@steiler steiler Awaiting requested review from steiler steiler is a code owner

@karimra karimra Awaiting requested review from karimra karimra is a code owner

@hansthienpondt hansthienpondt Awaiting requested review from hansthienpondt hansthienpondt is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alexandernorth @hansthienpondt