Skip to content

Conversation

@cezarmoise
Copy link
Contributor

@cezarmoise cezarmoise commented Oct 20, 2025

region is the correct name for that parameter, not aws_region.
No errors happen currently because all params go into a map, and aws_region is just never used.

It has no real consequences, most tests are triggered and given a region.
But in some cases, i.e. native backup, the region must match the bucket defined in the config.

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

Reminders

  • Add New configuration option and document them (in sdcm/sct_config.py)
  • Add unit tests to cover my changes (under unit-test/ folder)
  • Update the Readme/doc folder relevant to this change (if needed)

'region' is the correct name for that parameter, not 'aws_region'.
@cezarmoise cezarmoise changed the title fix(pipelins): replace aws_region with region fix(pipelines): replace aws_region with region Oct 20, 2025
@fruch
Copy link
Contributor

fruch commented Oct 20, 2025

@cezarmoise where ever the test that needs a specific region is trigger would need to keep that promise.

Why is holding us from duplicating the needed data into more regions ?

We started using multiple regions for performance tests, to avoid the problem of resources (and try to minimize noisy neighbors issues), and the ability to shift those tests into other regions might become important

@cezarmoise
Copy link
Contributor Author

@cezarmoise where ever the test that needs a specific region is trigger would need to keep that promise.

Why is holding us from duplicating the needed data into more regions ?

We started using multiple regions for performance tests, to avoid the problem of resources (and try to minimize noisy neighbors issues), and the ability to shift those tests into other regions might become important

It doesn't.
It's just that the name aws_region in the pipeline params is wrong, so the jenkinsfile and the jenkins job don't match.
I could just remove the region param altogether, but that would just use the default eu-west-1

Copy link
Contributor

@fruch fruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants