Skip to content

Conversation

@k0machi
Copy link
Contributor

@k0machi k0machi commented Oct 1, 2025

This is an update to the client that brings in new event system.

Testing

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

Reminders

  • Add New configuration option and document them (in sdcm/sct_config.py)
  • Add unit tests to cover my changes (under unit-test/ folder)
  • Update the Readme/doc folder relevant to this change (if needed)

This is an update to the client that brings in new event system.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this file have been ignored?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It keeps reappearing for some reason, maybe the packager isn't ignoring it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably yes, possibly needed there (I don't see it in argus repo)

Copy link
Contributor

@soyacz soyacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soyacz soyacz added backport/2024.1 Need backport to 2024.1 backport/2025.1 labels Oct 1, 2025
@k0machi
Copy link
Contributor Author

k0machi commented Oct 17, 2025

@soyacz

@soyacz
Copy link
Contributor

soyacz commented Oct 17, 2025

@fruch we already test events based on this PR and all seems to work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants