-
Notifications
You must be signed in to change notification settings - Fork 108
improvement(tests): Use pytest-xdist to run tests #11726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
3dafb8f
to
aa2b087
Compare
9856202
to
7f78d71
Compare
Reliably fails on CI due to: Probably overload? |
keep in mind the machine we are using for CI isn't not like you laptop. and as you can see it's making thing slower... and not faster. |
Its making them not work at all (for now). Can I see what is the problem, I see it is interrupted but I would like to know why. (Is it memory? is it CPU? is it some other limit being broken?) Also I do not think 4 workers should overload 4 CPU system |
We don't have any machinery like those for those tests You can connect to a running builder, or spin your own SCT runner with the same size, and experiment with it.
I don't know if it overload, bit having 12 cores running in 3 min, I would expect them to be slower when using 1/3 of the cores |
7f78d71
to
1b7c7aa
Compare
1b7c7aa
to
226a199
Compare
* Shortens runtime to around 6 minutes
226a199
to
5ea9331
Compare
v3:
It seems that since integration tests provision their own machine, paralelization is not a problem. I will do last few tests with unittests and if they do not still reliably work I will open another PR just for integration tests EDIT: It seems to work with two workers, which roughly halves the execution time (13 -> 7min), still valuable improvement in my opinion. |
Testing
PR pre-checks (self review)
backport
labelsReminders
sdcm/sct_config.py
)unit-test/
folder)