Adding option to push only post image events to kafka #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkropachev
force-pushed
the
dk/add-post-image-support
branch
2 times, most recently
from
59890aa to
0900a94
Compare
dkropachev
force-pushed
the
dk/add-post-image-support
branch
from
0900a94 to
c96fd1c
Compare
fee-mendes
reviewed
Mar 3, 2025
| case ROW_UPDATE: | ||
| return Envelope.Operation.UPDATE; | ||
| case ROW_INSERT: | ||
| case POST_IMAGE: |
There was a problem hiding this comment.
Perhaps we'd prefer the envelope to be returned by its respective delta op, similarly as we do with pre-images.
Otherwise, I won't be able to distinguish between create and update events. Arguably minor, but at least would keep semantics appropriately.
|
Thanks @dkropachev - added a single comment. I think the name I have a patch under cook if interested. |
dkropachev
force-pushed
the
master
branch
12 times, most recently
from
e924b3e to
d6de129
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.