Documentation fixes #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename logos directory to images as other types of images will be added in the following commits, which are not logos.
Add support information fields to Confluent packaging.
Remove information about connector being a preview release in README.
Clarify preimage/postimage point in Limitations section in README. Previous wording could suggest that there was some limited support instead of no support at all - intended message.
Add LICENSE.txt with Apache License 2.0. After moving the repositories, I forgot to copy this file.
|
Hi, Can you add a QUICKSTART guide with a docker-compose version? |
@avelanarius would that be a lot of work? |
haaawk
reviewed
May 12, 2021
README-QUICKSTART.md
Outdated
| ## Kafka setup | ||
|
|
||
| Scylla CDC Source Connector works well with both [open-source Kafka](https://kafka.apache.org/) | ||
| and [Confluent Platform](https://www.confluent.io/). In this quickstart we will show how |
There was a problem hiding this comment.
Maybe note here that the version of Kafka has to be high enough?
Add README-QUICKSTART documentation describing a step-by-step guide how to use the connector with a basic (non-production) configuration.
Cosmetic changes of configuration parameters: 1. Fixing capitalization of display names 2. Marking window size parameters as lower importance
avelanarius
force-pushed
the
confluent-fixes
branch
from
f1385cc to
d994c10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A batch of documentation fixes before the Confluent Verification:
One missing thing: when we release the next version of scylla-cdc-java, pom file should be updated to use the newer version.