Skip to content

Conversation

@shinthor
Copy link

@shinthor shinthor commented Jul 2, 2024

Simple addition of the layer argument which is already included in sc.tl.score_genes so that you can use your own layer instead of being restricted to what is stored in adata.X

  • Closes #
  • Tests included or not required because:
  • Release notes not necessary because:

@codecov
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.52%. Comparing base (208115d) to head (4ed4477).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3138   +/-   ##
=======================================
  Coverage   76.52%   76.52%           
=======================================
  Files         109      109           
  Lines       12483    12483           
=======================================
  Hits         9553     9553           
  Misses       2930     2930           
Files Coverage Δ
src/scanpy/tools/_score_genes.py 85.10% <0.00%> (ø)

@flying-sheep flying-sheep added this to the 1.11.0 milestone Jul 5, 2024
Copy link
Member

@flying-sheep flying-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Could you add a release note? This is a feature, so it would be in 1.11.0.md.

I wonder if it would be a good idea to do something like

s_name, g2m_name, phase_name = (
    f"{layer}_{name}" if layer else name for name in ("S_score", "G2M_score", "phase") 
)

and then use that, then multiple layers could be scored?

@flying-sheep flying-sheep modified the milestones: 1.11.0, 1.12.0 Dec 20, 2024
@shinthor shinthor changed the title add layer argument for sc.tl.score_genes_cell_cycle feat: add layer argument for sc.tl.score_genes_cell_cycle Aug 31, 2025
@flying-sheep
Copy link
Member

don’t forget to mark this as ready for review if you think it’s ready!

@shinthor shinthor marked this pull request as ready for review September 9, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants