-
Notifications
You must be signed in to change notification settings - Fork 675
feat: add layer argument for sc.tl.score_genes_cell_cycle #3138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3138 +/- ##
=======================================
Coverage 76.52% 76.52%
=======================================
Files 109 109
Lines 12483 12483
=======================================
Hits 9553 9553
Misses 2930 2930
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Could you add a release note? This is a feature, so it would be in 1.11.0.md.
I wonder if it would be a good idea to do something like
s_name, g2m_name, phase_name = (
f"{layer}_{name}" if layer else name for name in ("S_score", "G2M_score", "phase")
)and then use that, then multiple layers could be scored?
|
don’t forget to mark this as ready for review if you think it’s ready! |
Simple addition of the
layerargument which is already included insc.tl.score_genesso that you can use your own layer instead of being restricted to what is stored inadata.X