fix(coordinator): remove initialize euclid VKs
#1669
Conversation
WalkthroughThis change removes the Changes
Sequence Diagram(s)sequenceDiagram
participant Coordinator
participant Verifier
Coordinator->>Verifier: NewVerifier()
Note right of Verifier: Loads OpenVM Vks for "euclidv2" only
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (1.64.8)level=warning msg="[runner] Can't run linter goanalysis_metalinter: buildir: failed to load package zstd: could not load export data: no export data for "github.com/scroll-tech/da-codec/encoding/zstd"" ✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1669 +/- ##
===========================================
+ Coverage 40.94% 40.96% +0.01%
===========================================
Files 225 225
Lines 18071 18071
===========================================
+ Hits 7399 7402 +3
+ Misses 9950 9948 -2
+ Partials 722 721 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
common/types/message/message.go (2)
99-100: Apply the same constant-based approach for BatchTaskDetail.The
ForkNamefield comment here also relies on the literal"euclidv1". For consistency and to prevent typos, define and reference a constantEuclidV1ForkNameForProverinstead of a raw string.-// use one of the string of "euclidv1" / "euclidv2" +// use one of the string of EuclidV1ForkNameForProver / EuclidV2ForkNameForProver
112-113: Mirror the refactor in BundleTaskDetail.Again, switch from the raw
"euclidv1"literal to a shared constant for improved maintainability.-// use one of the string of "euclidv1" / "euclidv2" +// use one of the string of EuclidV1ForkNameForProver / EuclidV2ForkNameForProver
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
common/types/message/message.go(3 hunks)common/version/version.go(1 hunks)coordinator/internal/logic/verifier/verifier.go(0 hunks)
💤 Files with no reviewable changes (1)
- coordinator/internal/logic/verifier/verifier.go
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: tests
- GitHub Check: tests
- GitHub Check: tests
🔇 Additional comments (1)
common/version/version.go (1)
8-8:Details
✅ Verification successful
Approve version bump to v4.5.19.
Updating the
tagto"v4.5.19"aligns with the PR’s release plan. Ensure no leftover references to the old version remain elsewhere in the repo.To confirm cleanup:
🏁 Script executed:
#!/bin/bash rg -n "v4.5.18"Length of output: 15
To ensure we didn’t miss any literal occurrences of the old tag, let’s search using exact-string matches:
🏁 Script executed:
#!/bin/bash # Look for any exact matches of the previous version rg -F -n "v4.5.18" rg -F -n "4.5.18"Length of output: 36
Approved version bump to v4.5.19
Ran exact‐string searches for
v4.5.18and4.5.18—no matches found. No leftover references to the old version remain.
Purpose or design rationale of this PR
euclidverifier won't be initialized, thus removingloadOpenVMVksas well because it will calleuclidverifier'sdump_vkfunction.PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Deployment tag versioning
Has
tagincommon/version.gobeen updated or have you addedbump-versionlabel to this PR?Breaking change label
Does this PR have the
breaking-changelabel?Summary by CodeRabbit
Chores
Refactor