fix: l2 fee vault withdraw when using alt-gas-token #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiweichi
changed the base branch from
main
to
feat-deterministic-deployment
yiweichi
requested review from
0xmountaintop,
Thegaram and
zimpha
and removed request for
Thegaram
zimpha
approved these changes
Sep 26, 2024
0xmountaintop
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failed to withdraw l2 fee when using alternative gas token. because the logical conflict between:
https://github.com/scroll-tech/scroll-contracts/blob/feat-deterministic-deployment/src/alternative-gas-token/L1ScrollMessengerNonETH.sol#L85
https://github.com/scroll-tech/scroll-contracts/blob/feat-deterministic-deployment/src/L2/predeploys/L2TxFeeVault.sol#L123
So I implemented contracts L2TxFeeVaultWithGasToken to address this.