fix(feynman): fee ranges

[colinlyguo]

1. Purpose or design rationale of this PR

Fix 1: Change to baseFee - overhead to max(0, baseFee - overhead).
Fix 2: Bound max base fee after adding overhead, if the base fee is bounded excluding the overhead part here, it will fail the check here.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

• fix: A bug fix

3. Deployment tag versioning

Has the version in params/version.go been updated?

• Yes

4. Breaking change label

Does this PR have the breaking-change label?

• This PR is not a breaking change

Summary by CodeRabbit

• Bug Fixes
  • Improved base fee calculation to prevent negative values and ensure correct enforcement of maximum base fee caps.
• Chores
  • Updated the application patch version to 72.

[coderabbitai]

Walkthrough

This update centralizes the enforcement of the maximum base fee cap within the Feynman base fee calculation, removes redundant capping from the EIP-1559 path, and adds underflow protection to base fee extraction. Additionally, the patch version constant is incremented from 71 to 72.

Changes

File(s)	Summary of Changes
consensus/misc/eip1559.go	Moved max base fee cap enforcement to Feynman calculation, removed it from EIP-1559 calculation, added underflow protection in base fee extraction, and updated function signature to ignore unused config parameter.
params/version.go	Incremented VersionPatch constant from 71 to 72.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant eip1559 as eip1559.go
    Caller->>eip1559: calcBaseFeeFeynman()
    eip1559->>eip1559: Compute base fee + overhead
    eip1559->>eip1559: Clamp base fee to MaximumL2BaseFee if exceeded
    eip1559-->>Caller: Return capped base fee

    Caller->>eip1559: extractBaseFeeEIP1559(_, baseFee)
    eip1559->>eip1559: Subtract overhead from baseFee
    eip1559->>eip1559: If result < 0, return 0 instead
    eip1559-->>Caller: Return adjusted base fee

Loading

Possibly related PRs

• feat(feynman): L2 fee calculation #1199: Initially implemented the Feynman L2 fee calculation logic, which is directly refined and modified in this PR.

Suggested reviewers

• colinlyguo

Poem

In Feynman’s realm, a fee is capped,
No more confusion, the logic’s mapped.
Underflow’s gone, safe and sound,
Version seventy-two comes around.
Rabbits rejoice, the numbers align—
Hopping ahead, the code is fine!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3a5a705 and 9e79bea.

📒 Files selected for processing (1)

• params/version.go (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• params/version.go

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Analyze (go)

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[georgehao]

LGTM