Skip to content

feat: prevent large payload bytes print when compression is ineffective #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yiweichi merged 2 commits into from
Nov 28, 2025
Merged

feat: prevent large payload bytes print when compression is ineffective #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eeee0cb
perf: prevent large payload bytes print
yiweichi Nov 28, 2025
b5d7258
Merge branch 'main' into feat-improve-log
yiweichi Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions encoding/codecv7.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,13 +240,13 @@ func (d *DACodecV7) checkCompressedDataCompatibility(payloadBytes []byte, checkL
}

if err = checkCompressedDataCompatibilityV7(compressedPayloadBytes); err != nil {
log.Warn("Compressed data compatibility check failed", "err", err, "payloadBytes", hex.EncodeToString(payloadBytes), "compressedPayloadBytes", hex.EncodeToString(compressedPayloadBytes))
log.Warn("Compressed data compatibility check failed", "err", err, "payloadLen", len(payloadBytes), "compressedPayloadLen", len(compressedPayloadBytes))
return nil, false, nil
}

// check if compressed data is bigger or equal to the original data -> no need to compress
if checkLength && len(compressedPayloadBytes) >= len(payloadBytes) {
log.Warn("Compressed data is bigger or equal to the original data", "payloadBytes", hex.EncodeToString(payloadBytes), "compressedPayloadBytes", hex.EncodeToString(compressedPayloadBytes))
log.Warn("Compressed data is bigger or equal to the original data", "payloadLen", len(payloadBytes), "compressedPayloadLen", len(compressedPayloadBytes))
return nil, false, nil
}

Expand Down
4 changes: 2 additions & 2 deletions encoding/codecv8.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,13 @@ func (d *DACodecV8) checkCompressedDataCompatibility(payloadBytes []byte, checkL
}

if err = checkCompressedDataCompatibilityV7(compressedPayloadBytes); err != nil {
log.Warn("Compressed data compatibility check failed", "err", err, "payloadBytes", hex.EncodeToString(payloadBytes), "compressedPayloadBytes", hex.EncodeToString(compressedPayloadBytes))
log.Warn("Compressed data compatibility check failed", "err", err, "payloadLen", len(payloadBytes), "compressedPayloadLen", len(compressedPayloadBytes))
return nil, false, nil
}

// check if compressed data is bigger or equal to the original data -> no need to compress
if checkLength && len(compressedPayloadBytes) >= len(payloadBytes) {
log.Warn("Compressed data is bigger or equal to the original data", "payloadBytes", hex.EncodeToString(payloadBytes), "compressedPayloadBytes", hex.EncodeToString(compressedPayloadBytes))
log.Warn("Compressed data is bigger or equal to the original data", "payloadLen", len(payloadBytes), "compressedPayloadLen", len(compressedPayloadBytes))
return nil, false, nil
}

Expand Down
4 changes: 2 additions & 2 deletions encoding/codecv9.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,13 +51,13 @@ func (d *DACodecV9) checkCompressedDataCompatibility(payloadBytes []byte, checkL
}

if err = checkCompressedDataCompatibilityV9(compressedPayloadBytes); err != nil {
log.Warn("Compressed data compatibility check failed", "err", err, "payloadBytes", hex.EncodeToString(payloadBytes), "compressedPayloadBytes", hex.EncodeToString(compressedPayloadBytes))
log.Warn("Compressed data compatibility check failed", "err", err, "payloadLen", len(payloadBytes), "compressedPayloadLen", len(compressedPayloadBytes))
return nil, false, nil
}

// check if compressed data is bigger or equal to the original data -> no need to compress
if checkLength && len(compressedPayloadBytes) >= len(payloadBytes) {
log.Warn("Compressed data is bigger or equal to the original data", "payloadBytes", hex.EncodeToString(payloadBytes), "compressedPayloadBytes", hex.EncodeToString(compressedPayloadBytes))
log.Warn("Compressed data is bigger or equal to the original data", "payloadLen", len(payloadBytes), "compressedPayloadLen", len(compressedPayloadBytes))
return nil, false, nil
}

Expand Down