Skip to content

fix(zstd decompression): add correct usage of zstd library #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yiweichi merged 1 commit into from
Aug 25, 2025
Merged

fix(zstd decompression): add correct usage of zstd library #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions encoding/codecv7_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package encoding

import (
"bytes"
"encoding/binary"
"encoding/hex"
"encoding/json"
Expand Down Expand Up @@ -478,17 +477,14 @@ func (c *daChunkV7) Hash() (common.Hash, error) {

// decompressV7Bytes decompresses the given blob bytes into the original payload bytes.
func decompressV7Bytes(compressedBytes []byte) ([]byte, error) {
var res []byte

compressedBytes = append(zstdMagicNumber, compressedBytes...)
r := bytes.NewReader(compressedBytes)
zr, err := zstd.NewReader(r, zstd.WithDecoderConcurrency(1))
zr, err := zstd.NewReader(nil, zstd.WithDecoderConcurrency(1))
if err != nil {
return nil, fmt.Errorf("failed to create zstd reader: %w", err)
}
defer zr.Close()

res, err = zr.DecodeAll(compressedBytes, res)
res, err := zr.DecodeAll(compressedBytes, nil)
if err != nil {
return nil, fmt.Errorf("failed to decompress zstd data: %w", err)
}
Expand Down