Fix: basefold verify failure #1165
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Summary We added a new feature called `gpu`. Running with the cmd ``` RUST_LOG=info cargo test --release --package ceno_recursion --lib aggregation::tests::test_single --features "gpu" -- --exact ``` We can see the gpu prover's performance is like this (876160 instructions). ``` execute_metered [ 20.6ms | 100.00% ] execute_preflight [ 126ms | 66.19% / 100.00% ] trace_gen [ 431ms | 0.93% / 100.00% ] (⬆️ 😬) stark_prove_excluding_trace [ 183ms | 0.07% / 100.00% ] ``` And the cpu's prover print out log like this. ``` execute_metered [ 20.4ms | 100.00% ] execute_preflight [ 115ms | 65.98% / 100.00% ] trace_gen [ 252ms | 1.16% / 100.00% ] stark_prove_excluding_trace [ 3.52s | 0.12% / 100.00% ] ``` ### aggregate binary with gpu, we have ``` Aggregation - Start leaf proof (idx: 0) at: 1.031152699s INFO total_proof:stark_prove_excluding_trace: openvm_stark_backend::prover::coordinator: num_air=16 Aggregation - Completed leaf proof (idx: 0) at: 1.587258683s Aggregation - Start leaf proof (idx: 1) at: 1.587274907s INFO total_proof:stark_prove_excluding_trace: openvm_stark_backend::prover::coordinator: num_air=16 Aggregation - Completed leaf proof (idx: 1) at: 2.065737664s Aggregation - Start leaf proof (idx: 2) at: 2.065757212s INFO total_proof:stark_prove_excluding_trace: openvm_stark_backend::prover::coordinator: num_air=17 Aggregation - Completed leaf proof (idx: 2) at: 2.292657888s ``` without gpu, we end up with ``` Aggregation - Start leaf proof (idx: 0) at: 952.493241ms INFO total_proof:stark_prove_excluding_trace: openvm_stark_backend::prover::coordinator: num_air=16 Aggregation - Completed leaf proof (idx: 0) at: 7.603724584s Aggregation - Start leaf proof (idx: 1) at: 7.603750731s INFO total_proof:stark_prove_excluding_trace: openvm_stark_backend::prover::coordinator: num_air=16 Aggregation - Completed leaf proof (idx: 1) at: 14.088209165s Aggregation - Start leaf proof (idx: 2) at: 14.088250958s INFO total_proof:stark_prove_excluding_trace: openvm_stark_backend::prover::coordinator: num_air=17 Aggregation - Completed leaf proof (idx: 2) at: 18.048298693s ```
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 3, 2025
build on top of #1165 ### result shard circuit assignment of block `23817600` 41.163651057s -> 2.2301s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.