fix(3415): Do not treat "internal" repo as "private" #252
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Internal repositories are being marked and treated as private repositories.
The current logic in GitHub SCM module only relies on
privateproperty from the GitHub API response to identify whether a repository is private or not.But, this property alone is not sufficient. Both private and internal repositories will have
private: true.Objective
In addition to
privateproperty, we also need to check the value ofvisibilityproperty.private(Boolean)visibility(String)falsepublictrueprivatetrueinternalMark the repo as private when all the below criteria are met
References
screwdriver-cd/screwdriver#3415
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.