Skip to content

Conversation

@sagar1312
Copy link
Member

Context

Internal repositories are being marked and treated as private repositories.

The current logic in GitHub SCM module only relies on private property from the GitHub API response to identify whether a repository is private or not.
But, this property alone is not sufficient. Both private and internal repositories will have private: true.

Objective

In addition to private property, we also need to check the value of visibility property.

Repository Type API Property: private (Boolean) API Property: visibility (String) Description
Public false public Accessible to everyone on the internet.
Private true private Only accessible to the owner and explicitly shared collaborators/teams.
Internal true internal Accessible to all members of the organization/enterprise, but hidden from outsiders.

Mark the repo as private when all the below criteria are met

  • "private": true
  • "visibility": "private"

References

screwdriver-cd/screwdriver#3415

License

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@sagar1312 sagar1312 merged commit 711390f into master Oct 11, 2025
2 checks passed
@sagar1312 sagar1312 deleted the sagar1312-fix-3415-private_vs_internal_repo branch October 11, 2025 00:24
@sd-buildbot
Copy link

🎉 This PR is included in version 14.5.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants