Use latest version of Ubuntu #197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #197 +/- ##
=======================================
Coverage 95.96% 95.96%
=======================================
Files 6 6
Lines 471 471
Branches 90 90
=======================================
Hits 452 452
Misses 9 9
Partials 10 10 |
Member
Member
Author
|
@Gallaecio While i understand your point, i think the use case that you mentioned in the comment is more valid if the project rely on external packages/libraries. In our case we don't rely in any external package/library. So if the python interpreter is successfully installed we should not have any failing behaviour changing our runner. |
Gallaecio
approved these changes
Oct 24, 2022
Member
Gallaecio
left a comment
Gallaecio
left a comment
There was a problem hiding this comment.
That’s true. This is a pure Python package without dependencies. Which Ubuntu version we run should have no effect on tests. Thank you!
wRAR
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All workflows of Scrapy org runs on
ubuntu-latestrunner, except for w3lib and tests workflow of scrapyd that's is being handled here