update type annotation of auto_detect_fun param in html_to_unicode() #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #190 +/- ##
==========================================
- Coverage 96.04% 96.02% -0.02%
==========================================
Files 7 6 -1
Lines 480 478 -2
Branches 93 92 -1
==========================================
- Hits 461 459 -2
Misses 9 9
Partials 10 10
|
BurnzZ
commented
Sep 23, 2022
| html_body_str: bytes, | ||
| default_encoding: str = "utf8", | ||
| auto_detect_fun: Optional[Callable[[bytes], str]] = None, | ||
| auto_detect_fun: Optional[Callable[[bytes], Optional[str]]] = None, |
Member
Author
There was a problem hiding this comment.
Fixes https://github.com/scrapinghub/web-poet/pull/81/files#diff-0e01d80b02cf2bc35a0ad4643b60cf8fd9f065721e497677d92e6af2fdf3ab89R290 since the auto_detect_fun callable could actually return a None.
Member
|
👍 nice catch @BurnzZ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.