Enable nitpicky Sphinx warnings, fix issues and fail on new issues #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #140 +/- ##
=======================================
Coverage 95.43% 95.43%
=======================================
Files 7 7
Lines 482 482
Branches 98 98
=======================================
Hits 460 460
Misses 15 15
Partials 7 7 |
kmike
reviewed
Oct 18, 2019
|
|
||
| [tox] | ||
| envlist = py27, pypy, py34, py35, py36, py37, pypy3 | ||
| envlist = py27, pypy, py34, py35, py36, py37, pypy3, docs |
Member
There was a problem hiding this comment.
Could you please enable it on Travis as well?
Member
Author
|
Wow, the error seems too specific to be a false positive 🤔 |
Member
|
Yeah, looks like a genuine failure |
Member
Author
|
It’s a regression of https://bitbucket.org/pypy/pypy/issues/2389/different-behavior-of-bytesdecode-utf8 which @lopuhin reported to PyPy in 2016. His very example then can be used to reproduce the issue. |
Member
Author
|
@kmike If you are OK with running the tests on Python 2 PyPy 7.0.0 for now, we can squash and merge this. |
Member
|
Sounds good, thanks @Gallaecio! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.