Don't immediately close window on Gtk 2/3 #444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenCV does not implement WND_PROP_VISIBLE when compiled with Gtk 2 or 3. Instead it always returns -1, which extract_otp_secrets interprets as the window having been closed. See opencv/opencv#25346, which is marked as closed but actually still present in OpenCV 4.11.
novahahn
commented
Jul 9, 2025
| @@ -503,9 +510,6 @@ def cv2_handle_pressed_keys(qr_mode: QRMode, otps: Otps) -> Tuple[bool, QRMode]: | |||
| elif key == 32: | |||
| qr_mode = next_valid_qr_mode(qr_mode, zbar_available) | |||
| if verbose >= LogLevel.MORE_VERBOSE: print(f"QR reading mode: {qr_mode}") | |||
| if cv2.getWindowProperty(WINDOW_NAME, cv2.WND_PROP_VISIBLE) < 1: | |||
There was a problem hiding this comment.
Just changing < 1 to == 0 here also fixes the issue except that the script crashes when the window is closed on Gtk.
|
Thanks for your contribution. I've tested the PR on my machine and it still worked. Soon, I'll publish a new release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenCV does not implement WND_PROP_VISIBLE when compiled with Gtk 2 or 3. Instead it always returns -1, which extract_otp_secrets interprets as the window having been closed.
See opencv/opencv#25346, which is marked as closed but actually still present in OpenCV 4.11.