Skip to content

Conversation

henryiii
Copy link
Member

This now uses git subtree to make this easier to maintain. The build system is being synced with the other Scikit-HEP projects.

This also adds Python 3.8.

We might consider adding optional PEP 517 builds and using Setuptools's built-in Cython support in the future. But not right now (PyJet/NumPythia are testing that first).

git-subtree-dir: .ci/azure-wheel-helpers
git-subtree-split: 6b557614566f65a1f8d5122017adabb685ebecf2
@codecov
Copy link

codecov bot commented Dec 21, 2019

Codecov Report

Merging #371 into develop will increase coverage by 25.2%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #371      +/-   ##
===========================================
+ Coverage    65.98%   91.19%   +25.2%     
===========================================
  Files          139       17     -122     
  Lines         4469     1011    -3458     
  Branches       651       18     -633     
===========================================
- Hits          2949      922    -2027     
+ Misses        1282       79    -1203     
+ Partials       238       10     -228
Impacted Files Coverage Δ
Minuit/src/MnUserTransformation.cxx
Minuit/src/MnCovarianceSqueeze.cxx
Minuit/src/ModularFunctionMinimizer.cxx
Minuit/src/MnStrategy.cxx
Minuit/src/MnMinos.cxx
Minuit/inc/Minuit2/MinimumSeedGenerator.h
Minuit/src/LaSumOfElements.cxx
Minuit/inc/Minuit2/FunctionGradient.h
Minuit/inc/Minuit2/MnUserCovariance.h
Minuit/inc/Minuit2/MnCross.h
... and 113 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15c7e67...98bc56c. Read the comment docs.

@henryiii henryiii marked this pull request as ready for review December 21, 2019 04:58
@henryiii
Copy link
Member Author

Note: I think this needs to be "normally" merged, as git rebase tends to break git subtree.

@HDembinski HDembinski merged commit 316c118 into develop Dec 22, 2019
@HDembinski
Copy link
Member

Thank you for the update!

@HDembinski HDembinski deleted the henryiii-wheels branch February 4, 2020 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants