Sort input file list #355
Merged
Sort input file list #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that _libiminuit.so builds in a reproducible way in spite of indeterministic filesystem readdir order and http://bugs.python.org/issue30461 See https://reproducible-builds.org/ for why this is good.
Codecov Report
@@ Coverage Diff @@
## develop #355 +/- ##
========================================
Coverage 65.71% 65.71%
========================================
Files 137 137
Lines 4431 4431
Branches 651 651
========================================
Hits 2912 2912
Misses 1281 1281
Partials 238 238Continue to review full report at Codecov.
|
|
If I understand correctly, this change may help to make all binaries from the same build environment identical, which is certainly a good thing. Thank you for the PR! |
|
Yes, that is the goal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sort input file list
so that
_libiminuit.sobuilds in a reproducible wayin spite of indeterministic filesystem readdir order
and http://bugs.python.org/issue30461
See https://reproducible-builds.org/ for why this is good.
This PR was done while working on reproducible builds for openSUSE.