Set PYBIND11_FINDPYTHON ON to use FindPython CMake mode
#1023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please let me know if I need to add a manual CHANGELOG entry/fragment or just running |
Co-Authored-By: Henry Schreiner <[email protected]>
agriyakhetarpal
force-pushed
the
fix/set-findpython-via-pybind11
branch
from
a11b137 to
69b3dbb
Compare
1 task
|
Thank you for the patch. You don't need to update the changelog, that happens when I make the release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a small PR to configure the CMake 3.18+
FindPythonmode forpybind11to let it use the CMake search methods, in order to avoid having to pass the olderPython_ROOT_DIR/Python_INCLUDE_DIRmethods.I'm not sure if anything else needs to be configured further – the selected
noxsessions all pass on my machine locally and the recipe builds successfully within a Pyodide Docker container with this patch applied.Additional context