Skip to content

Conversation

ariostas
Copy link

@ariostas ariostas commented Apr 17, 2025

This is still a work in progress, but I'm opening this PR so I can ask questions about my changes, since I'm not familiar with how Coffea works.

This PR depends on scikit-hep/uproot5#1419

@lgray
Copy link
Collaborator

lgray commented Apr 17, 2025

Oh, cool! Thanks for starting this!

@lgray
Copy link
Collaborator

lgray commented Jul 29, 2025

Are we in a spot where we can start to wrap up this functionality @ariostas?

@ariostas
Copy link
Author

ariostas commented Jul 29, 2025

I think so. I was told that there was some major-ish refactoring underway and that I should wait. If that's done, I'm happy to get back to looking into this.

Although I'll probably wait a couple weeks to see what happens on the CMSSW side.

@ariostas
Copy link
Author

ariostas commented Aug 7, 2025

Quick update on this. After cms-sw/cmssw#48071 we can now produce RNTuple NanoAODs with CMSSW. The format is not final, but we can probably start playing around with it.

@lgray
Copy link
Collaborator

lgray commented Aug 28, 2025

@ariostas do you have anything further you'd like to do with this PR, shall we mark it ready for review?

It needs a rebase as well, there are some conflicts.

@ariostas
Copy link
Author

I'll spend some time on this next week. It probably mostly works, but I might need to make some changes on the Uproot side.

@lgray
Copy link
Collaborator

lgray commented Aug 29, 2025

@ariostas OK - great, thanks! Please keep me informed!

@ariostas ariostas force-pushed the ariostas/rntuple_support branch from 6ba606c to ffcea34 Compare September 5, 2025 19:24
@ariostas
Copy link
Author

ariostas commented Sep 5, 2025

Quick update on this. Now that coffea switched to virtual arrays by default, it seems like we don't need any changes on the Uproot side.

I got it to read the form correctly, but it is failing to materialize the arrays. I'm guessing that it's because it's assuming that all fields are at the top level, but I'll have to look into it.

@lgray
Copy link
Collaborator

lgray commented Sep 5, 2025

Awesome - thanks for coming back to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants