fix: add missing f-string prefix for --parallel bootstrap arg #665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The --parallel={parallel} argument was a regular string instead of an
f-string, causing it to literally pass "--parallel={parallel}" to the
cmake bootstrap script instead of the actual parallel job count.
This resulted in single-threaded bootstrap compilation regardless of
CMAKE_BUILD_PARALLEL_LEVEL setting.
Contributor
Author
|
Some less-than-scientific before / after evidence: Before 
After 
|
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--parallel={parallel}argument in_build_backend/backend.pywas a regular string instead of an f-string, causing it to literally pass--parallel={parallel}to the cmake bootstrap script instead of the actual parallel job count.This resulted in single-threaded bootstrap compilation regardless of
CMAKE_BUILD_PARALLEL_LEVELsetting.The fix is simply adding the
fprefix to make itf"--parallel={parallel}".