Always call `bar.Finish()` in `Reader` #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

mrkbac wants to merge 1 commit into schollz:main from mrkbac:fix-reader-close

mrkbac commented May 16, 2025

In the current implementation, bar.Finish() is never called if the underlying io.Reader also implements io.Closer.


          fix: Always call Finish() in Reader

9d2ae6b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet