Skip to content

Conversation

arunkannawadi
Copy link
Collaborator

@arunkannawadi arunkannawadi commented Oct 19, 2022

Fixes #444.

Description

If the highly-cited publication is fetched from an author's profile, then scholarly will look at the annual citation histogram and adapt the year ranges to fetch as many citations as possible without exceeding 1000. This will minimize the number of queries, especially if there are years with very few citations.

Checklist

  • Check that the base branch is set to develop and not main.
  • Ensure that the documentation will be consistent with the code upon merging.
  • Add a line or a few lines that check the new features added.
  • Ensure that unit tests pass.
    If you don't have a premium proxy, some of the tests will be skipped.
    The tests that are run should pass without raising
    MaxTriesExceededException or other exceptions.

@arunkannawadi
Copy link
Collaborator Author

Pinging @jjshoots if you'd like to look at the changes that I added on top of your commits.

@arunkannawadi arunkannawadi force-pushed the develop branch 2 times, most recently from 629fdd5 to 768bc48 Compare October 19, 2022 18:46
@arunkannawadi arunkannawadi force-pushed the develop branch 4 times, most recently from 494e4fa to fabc957 Compare October 19, 2022 23:16
@arunkannawadi arunkannawadi changed the base branch from develop to main October 19, 2022 23:26
@arunkannawadi arunkannawadi changed the base branch from main to develop October 20, 2022 17:57
@arunkannawadi arunkannawadi merged commit 04275ba into develop Oct 20, 2022
@arunkannawadi arunkannawadi deleted the citedby1k branch October 20, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants