Skip to content

Conversation

@bsodmike
Copy link

In Ruby 1.8 String was a collection of bytes, moving to 1.9 it's both the raw bytes and the attached Encoding information.

Works on Ruby 1.9.3-p0, Mac OS X Lion 10.7.2

@bsodmike
Copy link
Author

Hi @goncalossilva- I just updated it to ensure compatibility with Ruby 1.8.x as well =)

@bsodmike
Copy link
Author

Update- I decide to stick with slide_subsection and cleaned it up a bit. Tested with 1.8.7-p334 and 1.9.3-p0

@goncalossilva
Copy link
Collaborator

I don't feel confortable with just forcing that string to be UTF-8. I'd prefer to use Encoding.default_internal and Encoding.default_external to achieve this.

However, I was trying to reproduce this bug and couldn't do it. It's possible that one of the recent changes also fixed this. Could you provide a simple example which fails against master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants