Skip to content

fix(build): ts strict mode #1507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Nov 18, 2025
Merged

fix(build): ts strict mode #1507

merged 11 commits into from
Nov 18, 2025
+6,002 −4,807

Conversation

@Lunkan89
Copy link
Collaborator

@Lunkan89 Lunkan89 commented Oct 17, 2025 •
edited
Loading

Describe pull-request

Started on using strict mode

Issue Linking:

Choose one of the following options

@aws-amplify-eu-north-1
Copy link

aws-amplify-eu-north-1 bot commented Oct 17, 2025

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1507.d3fazya28914g3.amplifyapp.com

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2025 •
edited
Loading

Accessibility Test results

passed  76 passed

Details

stats  76 tests across 76 suites
duration  23.1 seconds
commit  ddd8d15

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2025 •
edited
Loading

Playwright test results

passed  807 passed
skipped  1 skipped

Details

stats  808 tests across 137 suites
duration  2 minutes, 3 seconds
commit  ddd8d15

Skipped tests

src/components/table/table/test/expandable-row-autocollapse/expandable-row-autocollapse.e2e.ts › tds-table-expandable-row-autoCollapse › NEEDS FIXING: expanding one row collapses the others when autoCollapse is true

@Lunkan89 Lunkan89 marked this pull request as ready for review October 21, 2025 08:21
@Lunkan89 Lunkan89 requested a review from a team as a code owner October 21, 2025 08:21
ckrook
ckrook reviewed Oct 22, 2025
View reviewed changes
ckrook
ckrook reviewed Oct 22, 2025
View reviewed changes
@Lunkan89 Lunkan89 requested a review from ckrook October 22, 2025 08:21
ckrook
ckrook reviewed Oct 22, 2025
View reviewed changes
ckrook
ckrook reviewed Oct 23, 2025
View reviewed changes
@Lunkan89 Lunkan89 requested a review from a team October 23, 2025 08:26
lkritsimas
lkritsimas reviewed Oct 27, 2025
View reviewed changes
augustinescania
augustinescania approved these changes Nov 4, 2025
View reviewed changes
Copy link
Collaborator

@augustinescania augustinescania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a starting point for adopting strict mode, this looks really solid.
Great work @Lunkan89!

timrombergjakobsson
timrombergjakobsson approved these changes Nov 5, 2025
View reviewed changes
Copy link
Contributor

@timrombergjakobsson timrombergjakobsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When conflicts are resolved I would say go for it!

@Lunkan89 Lunkan89 force-pushed the fix/ts-strict-mode branch 3 times, most recently from f5d065e to b6beee0 Compare November 12, 2025 07:14
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 18, 2025

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.5% Duplication on New Code

See analysis details on SonarQube Cloud

@timrombergjakobsson timrombergjakobsson merged commit e9b640e into develop Nov 18, 2025
4 checks passed
@timrombergjakobsson timrombergjakobsson deleted the fix/ts-strict-mode branch November 18, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lkritsimas lkritsimas lkritsimas left review comments

@timrombergjakobsson timrombergjakobsson timrombergjakobsson approved these changes

@ckrook ckrook ckrook approved these changes

@augustinescania augustinescania augustinescania approved these changes

@MartinPiq MartinPiq Awaiting requested review from MartinPiq

Assignees

@Lunkan89 Lunkan89

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Lunkan89 @timrombergjakobsson @ckrook @lkritsimas @augustinescania