Skip to content

Conversation

anurag4DSB
Copy link

WIP: need to add tests and see for potential other options, this is the first potential logical fix.
also need to experiement and think about edge cases which can happen.

Copy link

codecov bot commented Oct 17, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.20%. Comparing base (9466566) to head (024541a).
⚠️ Report is 1 commits behind head on bugfix/S3CSI-195-fix-node-publish-creds-usage.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...g/driver/controller/credentialprovider/provider.go 33.33% 6 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
pkg/driver/controller.go 77.70% <100.00%> (+1.19%) ⬆️
.../driver/node/credentialprovider/provider_secret.go 100.00% <ø> (ø)
...g/driver/controller/credentialprovider/provider.go 79.75% <33.33%> (-3.69%) ⬇️

... and 1 file with indirect coverage changes

@@                                Coverage Diff                                @@
##           bugfix/S3CSI-195-fix-node-publish-creds-usage     #269      +/-   ##
=================================================================================
- Coverage                                          71.61%   71.20%   -0.42%     
=================================================================================
  Files                                                 47       47              
  Lines                                               3414     3441      +27     
=================================================================================
+ Hits                                                2445     2450       +5     
- Misses                                               839      859      +20     
- Partials                                             130      132       +2     

Base automatically changed from bugfix/S3CSI-195-fix-node-publish-creds-usage to main October 18, 2025 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant