Skip to content

Conversation

@kitbellew
Copy link
Collaborator

scala-native doesn't need to run on push since we don't need to upload artifacts, and building is already verified as part of test.

scala-native doesn't need to run on push since we don't need to upload
artifacts, and building is already verified as part of `test`.
@kitbellew kitbellew requested a review from tgodzik January 29, 2025 16:51
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also do that for native image?

@kitbellew
Copy link
Collaborator Author

Should we also do that for native image?

we could. here's what i thought:

  1. we will remove it soon, so might as well not touch it :)
  2. scala-native is always built as part of the test job (and then run), so the only difference is copying and then uploading which we don't need to test
  3. native-image, however, involves some other steps which could potentially broken and only discovered after a release, so might be a reasonable check to keep for now.

let me know what you think.

@tgodzik
Copy link
Contributor

tgodzik commented Jan 29, 2025

Makes sense, let's keep it then

@kitbellew kitbellew merged commit 073d5f9 into scalameta:main Jan 29, 2025
32 checks passed
@kitbellew kitbellew deleted the 4763 branch January 29, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants